Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway metric for nohost #1958

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

bennerv
Copy link
Collaborator

@bennerv bennerv commented Feb 10, 2022

Which issue this PR addresses:

ADO 13137631

What this PR does / why we need it:

Adds a metric when there does not exist a host in the http/https request coming to the gateway.

It additionally logs the linkID the request is coming from so we can view which clusters are having issues.

Test plan for issue:

Run it and check updated metric.

Is there any documentation that needs to be updated for this PR?

Need an associated dashboard which is part of the story.

@m1kola
Copy link
Contributor

m1kola commented Feb 14, 2022

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@ross-bryan ross-bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bennerv bennerv merged commit dbbd2fc into Azure:master Feb 16, 2022
@bennerv bennerv deleted the add-gateway-metric-for-nohost branch February 16, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants